Skip to content

PYTHON-4565 - Use pytest markers for test suite configuration #1741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 23, 2024

Conversation

NoahStapp
Copy link
Contributor

No description provided.

@mongodb-drivers-pr-bot mongodb-drivers-pr-bot bot requested a review from Jibola July 22, 2024 23:35
@NoahStapp
Copy link
Contributor Author

I can't reproduce the typechecking failures locally, could it be a toolchain issue?

@blink1073
Copy link
Member

blink1073 commented Jul 23, 2024

PyOpenSSL just had a release, you might be using an older version locally.

@NoahStapp
Copy link
Contributor Author

PyOpenSSL just had a release, you might be using an older version locally.

Just updated to the newest version, still no issue locally.

@blink1073
Copy link
Member

It isn't the toolchain, because it is happening on GitHub.

@blink1073
Copy link
Member

Note it also occurs in #1742

@blink1073
Copy link
Member

Ah, they just recently added type hints to the library itself, I assume we were using types-pyopenssl before. Can you open a ticket?

https://github.com/pyca/pyopenssl/blob/main/src/OpenSSL/py.typed

@NoahStapp
Copy link
Contributor Author

Ah, they just recently added type hints to the library itself, I assume we were using types-pyopenssl before. Can you open a ticket?

pyca/pyopenssl@main/src/OpenSSL/py.typed

Did we explicitly include types-pyopenssl anywhere? I don't see any references.

@blink1073
Copy link
Member

Did we explicitly include types-pyopenssl anywhere? I don't see any references.

It gets pulled in by --install-types if there is no py.typed in the package.

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blink1073 blink1073 merged commit 993171c into mongodb:master Jul 23, 2024
28 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants